Skip to content

test: standardise mock and setup file and testing related folder names#1209

Open
poltorak wants to merge 3 commits intomainfrom
refactor/cosmetic-cleanup-and-changes
Open

test: standardise mock and setup file and testing related folder names#1209
poltorak wants to merge 3 commits intomainfrom
refactor/cosmetic-cleanup-and-changes

Conversation

@poltorak
Copy link
Collaborator

@poltorak poltorak commented Jan 9, 2026 •
edited
Loading

Covers #1168

Standardize Folder Naming

Scope: Renamed mock → mocks folders for consistency
Files affected: 8 files across examples and nx-plugin packages
Impact: Pure renaming with corresponding import path updates

Files changed:

examples/plugins/src/lighthouse/mock/ → mocks/
packages/nx-plugin/mock/ → mocks/
Updated import references in test files and documentation

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 nx-plugin 🛠️ tooling labels Jan 9, 2026
@nx-cloud
Copy link

nx-cloud bot commented Jan 9, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 574f147

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 34s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 13m 38s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 10s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-29 12:48:26 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 9, 2026 •
edited
Loading

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1209

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1209

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1209

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1209

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1209

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1209

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1209

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1209

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1209

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1209

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1209

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1209

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1209

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1209

commit: 574f147

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 695b268 with previous commit 5f35b7a.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 32 🔴 33 ↑ +1.7
Code coverage 🟢 93 🟢 93 ↓ −0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 100 🟢 100 –
Security 🔴 47 🔴 47 –
Updates 🟡 78 🟡 78 –
Type Safety 🟡 67 🟡 67 –
Miscellaneous 🟡 67 🟡 67 –
Documentation 🟡 53 🟡 53 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟢 92 🟢 92 –
👍 1 group improved, 👎 1 group regressed, 👍 5 audits improved, 👎 2 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 32 🔴 33 ↑ +1.7
Code coverage Code coverage metrics 🟢 93 🟢 93 ↓ −0.1

32 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 7.5 s 🟥 6.8 s ↓ −9.2 %
Lighthouse First Contentful Paint 🟥 3.5 s 🟥 3.4 s ↓ −2.4 %
Lighthouse Time to Interactive 🟥 14.7 s 🟥 13.5 s ↓ −8 %
Lighthouse Total Blocking Time 🟥 3,470 ms 🟥 2,600 ms ↓ −25.1 %
Code coverage Line coverage 🟩 92.7 % 🟩 92.6 % ↓ −0.1 %
Code coverage Branch coverage 🟨 89.2 % 🟨 89.2 % ↑ +0.1 %
Code coverage Function coverage 🟩 94.3 % 🟩 94.3 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 13.9 s 🟥 10.7 s ↓ −22.6 %
Lighthouse JavaScript execution time 🟥 6.2 s 🟥 4.3 s ↓ −32 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,094 KiB 🟩 Total size was 2,092 KiB ↓ −0.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −8 %
Lighthouse Largest Contentful Paint 🟥 12.7 s 🟥 11.7 s ↓ −7.6 %
Lighthouse Max Potential First Input Delay 🟥 2,180 ms 🟥 1,230 ms ↓ −43.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 87 KiB 🟥 Potential savings of 86 KiB ↑ +200 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 125 KiB 🟥 Potential savings of 125 KiB ↑ +63 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 228 KiB 🟥 Potential savings of 225 KiB ↑ +30.4 %
Lighthouse Server Backend Latencies 🟩 680 ms 🟩 800 ms ↑ +16.6 %
Lighthouse Initial server response time was short 🟩 Root document took 540 ms 🟩 Root document took 600 ms ↑ +10.2 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 70 ms ↑ +8.8 %
JS packages Outdated npm prod dependencies. 🟨 18 outdated package versions (5 major, 11 minor, 2 patch) 🟨 19 outdated package versions (5 major, 11 minor, 3 patch) ↑ +5.6 %

658 other audits are unchanged.

@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch 2 times, most recently from 777ce08 to 4fb2ca7 Compare January 9, 2026 12:01
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 695b268 with previous commit 5f35b7a.

💼 Project nx-plugin

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 91 🟢 92 ↑ +0.2

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved, 👎 2 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 91 🟢 92 ↑ +0.2

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 80.8 % 🟨 81.7 % ↑ +1.1 %
Code coverage Line coverage 🟩 93.2 % 🟩 93 % ↓ −0.2 %
Code coverage Function coverage 🟩 96.4 % 🟩 96.3 % ↓ −0.1 %

445 other audits are unchanged.

💼 Project plugin-lighthouse

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

All of 6 categories are unchanged.

1 audit changed without impacting score

🗃️ Groups

All of 15 groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟩 98.8 % 🟩 98.8 % ↓ −0.1 %

443 other audits are unchanged.

12 other projects are unchanged.

@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from 4fb2ca7 to cdb82a1 Compare January 9, 2026 12:37
BioPhoton
BioPhoton requested changes Jan 9, 2026
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split mock folder renaming and setup script refactoring into 2 PR's pls.
I have some more comments on the test setup that would delay the mock renaming part.

Also i already renamed your PR to: "test: standardise mocks folder names" so I can add my feedback related to the renaming here.

@BioPhoton BioPhoton changed the title Refactor: cosmetic cleanup and changes test: standardise mocks folder names Jan 9, 2026
@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from cdb82a1 to ffbe58d Compare January 12, 2026 08:17
@poltorak
Copy link
Collaborator Author

poltorak commented Jan 12, 2026

Could you split mock folder renaming and setup script refactoring into 2 PR's pls. I have some more comments on the test setup that would delay the mock renaming part.

Done, current PR contains only mocks rename

@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from ffbe58d to 961e2d8 Compare January 12, 2026 08:25
@poltorak poltorak marked this pull request as ready for review January 12, 2026 08:33
BioPhoton
BioPhoton reviewed Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! I left a suggestion for improvement.

BioPhoton
BioPhoton requested changes Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the update! This will be a really nice alignment!

One last thing we could do is categorise our file types. (Im not 100% sure about the additional work so feel free to skip it if not super quick.)
e.g. performance.mock.ts contains the MockPerformanceObserver class and perf-hooks.setup-file.ts has the vi.mock call that uses performance.mock.ts exports.

Then test-utils would countain only helper (*.mock.ts or just plain helper functions like setupTestFolder) and test-setup would use them inside *.setup-file.ts files and contain the vi.mock, beforeEach etc.

@BioPhoton BioPhoton changed the title test: standardise mocks folder names test: standardise mock and setup file and testing related folder names Jan 14, 2026
@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from fa7b6bb to bbd1d10 Compare January 20, 2026 15:41
@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from bbd1d10 to 574f147 Compare January 29, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BioPhoton BioPhoton BioPhoton requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@poltorak poltorak

Labels

🧩 nx-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@poltorak @BioPhoton